Name that refactoring: 2 - Version 2 38

Posted by Brett Schuchert Wed, 16 Dec 2009 08:14:00 GMT

A few updates applied to the second name that refactoring. Note that I’m using a star to represent a problem dependency. It is the “star” of the refactoring. I’m looking for a better image. I could go with a database icon, but the principle is more general than that. The cloud was confusing. So if you have an idea, please let me know what it is!

Again, thanks for taking a look and giving me the feedback.

Step 0: Problematic Dependency

Step 1: Capture dependency in a single class

Step 2: Raise the abstraction to a domain-level interface

Step 3: Introduce test doubles as needed

Comments

Leave a response

  1. Avatar
    Giorgio Sironi about 2 hours later:

    As long as you are consistent in using the star there are no problems, but maybe a more expressive image can help. The cloud was too specific as it points only to Internet dependencies.

  2. Avatar
    abi about 2 hours later:

    What is the significance of test double? Is it for making sure that the code doesnt break?

  3. Avatar
    r. about 7 hours later:

    I preferred the “cloud” as it more underline a potentially complex dependency system.

  4. Avatar
    Daniel Meyer about 9 hours later:

    Somehow this version is much clearer to me than the original version. I think the arrows pointing to the dependencies must help me – and also the terse description text below each figure.

    I couldn’t seem to connect with the original version but I got excited when I saw this one, because I could see myself pointing to these and teaching the concept to a co-worker.

    It’s also helpful that the step-by-step changes are all on the same screen – I found my eyes jumping up and down the chain of diagrams many times as I absorbed the small difference between each consecutive pair. (It would lose something important, for instance, if each diagram were on a separate page or slide).

  5. Avatar
    Dan Bernier about 11 hours later:

    I also dislike the star. If it’s too positive, what do we find if we swing to the other side? What about a bomb, a skull & crossbones? Those may be too harsh—the dependency isn’t fatal, it’s just undesirable.

    The “code smells” metaphor suggests a whole range of potential images…

  6. Avatar
    Jacob Stanley about 15 hours later:

    I think the star is too positive. Even though I know what it represents, my emotional side is thinking that it’s bad to move the star further away – after all, he’s so friendly :)

  7. Avatar
    Brett L. Schuchert about 24 hours later:

    Hum…. I know the star is a bit cheese, but it is, after all, the star of the refactoring!-)

    I’ll keep looking. I saw one idea. I’ve privately been given several inappropriate recommendations as well.

  8. Avatar
    Rob Godfrey 1 day later:

    How about a target symbol instead of a star, as in the target of the refactoring.

  9. Avatar
    Chris Salter 2 days later:

    It’s funny… When I looked at the first version, even after I figured it out, I never connected it with anything I’ve done. The minute I saw this one, I immediately thought of a project I worked on a few months ago.

    The star may not be perfect, but it’s worlds better than the cloud. Personally, I think it would be more fun with a T-Rex.

  10. Avatar
    Darioush Jalali 3 days later:

    I also found the cloud more expressive, the idea that the cloud represents “something general that we don’t show in detail here” is a widely accepted metaphor. Anyhow star or cloud keep up the good work up!

  11. Avatar
    Esko Luontola 4 days later:

    T-Rex sounds nice. It’s something which we want to keep far away from us. :D

    Some ideas I had (but which the spam filter ate) were a weight (10 tons, like in many cartoons) – it’s something heavy which slows us down. Or then a padlock – it’s something which prevents us from progressing.

  12. Avatar
    Cyrille Martraire 14 days later:

    a weight (10 tons, like in many cartoons) – it’s something heavy which slows us down>

    - exactly, this is also how I feel about a painful dependency.

  13. Avatar
    hal? y?kama makinas? 23 days later:

    I’ll keep looking. I saw one idea. I’ve privately been given several inappropriate recommendations as well. Thanks.

  14. Avatar
    Koltuk Yikama 23 days later:

    I preferred the cloud as it more underline a potentially complex dependency good system

  15. Avatar
    janeyi 3 months later:

    If,overhead trolleyif you’re ,trolley conveyor if you’

    re hounded by people trying to bring you down, turn rollerdemanding your time and attention, X678 you can afford to be direct. X458 Because truth

    cuts through the bullshit.yy2010.3.24

  16. Avatar
    Blu-ray ripper mac 4 months later:

    Free download Blu-ray to iPad Mac, you can easily convert Blu ray and DVDs to iPad for playing.

  17. Avatar
    Pandora 12 months later:

    but that all attempts to improve quality would be short lived and followed by a larger drive to decrease quality even further.

  18. Avatar
    http://www.blacktowhiteiphone4.com about 1 year later:

    now supplying the latest white iphone 4 conversion kit to make your iphone 4 different from others. As a fashion fans like you will surely love it.

  19. Avatar
    oppell about 1 year later:

    Thank you for sharing, I recently saw some of the content of concessions, such as: air max air jordan Now there are discounts website, the address is: www.oppell.com Thank you!c

  20. Avatar
    electronic ballast about 1 year later:

    Your site is amazing.I am very impressed to see this,i want to come back for visiting your site.Keep doing Good as well as you can.

  21. Avatar
    disney about 1 year later:

    Everyone has different growth process, maybe some feel difficult in his or her childhood memory, or others may think that this is a happy ending. Now, there is a adays boxset hot and popular Disney was growing pains is about growing pains as we all know, different people have different ideas. As such, it tells DVD boxset growing pains, the actor has troubled childhood, but he never gave up Dvd And Movie. Finally, he become a person of success, have a happy family, so like us, we must work harder to study, work harder what be what to write, we also must have a dream, never give up, in the end, we all have a bright future. Tell us a lot of useful things, our whole life whether you have time, you had Disney Dvds better buy the growth process full season, you will DVD benefited.

  22. Avatar
    okey oyunu oyna about 1 year later:

    Thanks.

    internette görüntülü olarak okey oyunu oyna, gerçek kisilerle tanis, turnuva heyecanini yasa.

  23. Avatar
    wholesale imitation jewelry about 1 year later:

    I preferred the cloud as it more underline a potentially complex dependency good system

  24. Avatar
    bagsupplyer about 1 year later:
  25. Avatar
    abercrombie and fitch about 1 year later:

    If Abercrombie & Fitch is really concerned that the Situation and company have appeared on air in its garments, it doesn’t appear that angry.Bienvenue pour parcourir Abercrombie France site en ligne, vente en ligne New Style Belstaff en France, vous pouvez acheter la qualite superieure et escompte.Teen apparel retailer Abercrombie & Fitch Co. is offering to pay Michael “The Situation” Sorrentino not to wear its merchandise.Abercrombie Paris est le vêtement de la marque originale et riche d’une histoire enracinee dans le grand air et de la cote Est Ivy League.

  26. Avatar
    chaussureslouboutin about 1 year later:
    At some time extensive most effective low-priced MBT Kafala Boots and shoes discounted design all these cycles boots and shoes, Jimmy Choo Pompesyou may the radical the answers.Jimmy Choo Sandales Quite a few job opportunities have to have you actually often be humiliated with you, fully to the specific shape, ankles,

    North Face Apex Bionic Kvinder Jakker

    plus thighs and leg,

    the north face

    plus improved during losing fat laden calories might move barefoot in the inclusion. In that case keep account.

    December 2012 will be to can comecanada goose jakke, lots of believers live 2012 is just about the most important issue with discourse. mbt internet profit internationally renowned students will be guessing devastating incidents which is nearly anything. Let’ vertisements evaluate ways to live 2012canada goose , principally around the best way far better create you actually for any predictable.

  27. Avatar
    Casey Stubbs about 1 year later:

    Just stumbled across your blog and was instantly amazed with all the useful information that is on it. Great post, just what i was looking for and i am looking forward to reading your other posts soon!

  28. Avatar
    Christian about 1 year later:

    asas d+0fa7s0+d9 7as+d d70gs

  29. Avatar
    moncler about 1 year later:

    asdfas d+0f9asd+f9 8sgdddd

  30. Avatar
    Louboutins about 1 year later:

    asda sdf4dsg444

  31. Avatar
    Air Jordan Max Fusion about 1 year later:

    A excellent dude is invariably ready to acquire little.

  32. Avatar
    Buy Nike Air Yeezy about 1 year later:

    The worst method to forget some one is for getting sitting centerbesidehim knowing you cant have him.

  33. Avatar
    the north face outlet about 1 year later:

    Was looking for well-thought piece of writing. Instant messaging in actual fact at the workplace today! Therefore I will need to disappear without the need of reviewing virtually all No . for instance. Nonetheless, My spouse and I position your web site website on my little Feed to make certain that I will endure considerably more.

  34. Avatar
    moncler sito ufficiale about 1 year later:

    Moncler fa oscurare quasi 500 siti web. Con una sentenza moncler sito ufficialedel tribunale di Padova, Italy. Ma non è proprio così, solo pochi di quei siti vendevano moncler uomoprodotti contraffatti, altri erano canada goose outletdomini acquistati da utenti. Infatti la cosa clamorosa Moncler Borsenon è la sentenza per oscurare siti belstaff outletaccusati di contraffazione o ricettazione, ma chemoncler sito ufficiale il giudice abbia ritenuto un reato di contraffazione la registrazione di un indirizzo web Moncler Sweater Donnecontenente il marchio dell’azienda. I siti di appassionati di qualcosa, i tenutari di pagine Fan su facebook, ugg ???tutti tremano: la strada ell’oscurantismo in moncler uomoItalia si fa sempre più larga, e quindi? Intorno a me, who cares?

  35. Avatar
    http://www.uggssale2011.com about 1 year later:

    UGG Stiefel günstig , wenn Sie zufällig das Glück, in einer Gemeinschaft, die eine Gemeinschaft wohnen Hochschule sicherstellen, dass Sie wirklich Zeit in Ihren Zeitplan sicher zu sein und sehen, welche Art von Klassen, die sie anbieten könnte, die helfen können Ihr career.You kann in den verschiedenen Arten der Kurse, die Sie selbst nehmen können auf die Gemeinde erstaunt sein, leihen Sie sich Ihre Ausbildung Hochschulbildung level.I wissen, dass ich einige von den Kursen, die angeboten werden und ihre Ausbildung zu finden, darauf hin, dass die möglicherweise zufällig ganz exceptional.I denke, dass viele die, die in den letzten haben die Schlüsselrolle, die in der Regel Gemeinde Bildungseinrichtungen vernachlässigt entdeckt Institutionen spielen mit der Bereitstellung einer Low-Cost Austragungsort für das Lernen entwickelt werden könnten ganz erstaunt too.Community Hochschulen mit einem unverdienten Erfolgsbilanz für Minderwertigkeitsgefühle kommen, wenn diese nicht am Ende kann bis weiter in die truth.A gut viele Nationen, Pflegepersonal sind Dienste der Nachbarschaft College educations.In mehrere Staaten, die Associate Degree Pflege-Programmen recht strenge und liefern mehr medizinische Erfahrung im Vergleich zu den meisten Bachelor-Abschluss suchen nach programs.Which bedeutet, dass Absolventen Krankenpflegeschule mit einem Mitarbeiter Betrag in der Pflege sind oft besser vorbereitet zu bewältigen Patient Gesundheitswesen als jeder, der die “höheren Grad” hat.

  36. Avatar
    Somanabolic Muscle Maximizer over 2 years later:

    I found this an informative and interesting article so i think so it is very useful and knowledgeable. I would like to thank you for the work you have made in writing this article. I am wish the same best work from you in the future as well

  37. Avatar
    Forex Profit Predictor bonus over 2 years later:

    Thanks for your personal marvelous posting! I really enjoyed reading it, you are a great author.I will be sure to bookmark your blog and may come back someday. I want to encourage you continue your great work, have a nice evening!

  38. Avatar
    ralph lauren over 2 years later:

    Hiver n’est pas terminée, mais les grandes marques ont commencé le début de ce printemps, Ralph Lauren est l’un d’entre eux. Marque sous le soleil printanier et séries allé à los angeles plage en Californie, Etats-Unis, avec le thème de los angeles côte de los angeles Californie, los angeles série de femmes répartis en Californie du Nord avec not layout bohème et setting rétro, comme theme flower, robe en mousseline de soie corps mince et ainsi de range.http://www.vetementpoloralphlauren2012.net

Comments