Object Mentor Blog: Name that refactoring: 2 - Version 2

Name that refactoring: 2 - Version 2

Brett Schuchert — Wed, 16 Dec 2009 02:14:00 -0600

A few updates applied to the second name that refactoring. Note that I’m using a star to represent a problem dependency. It is the “star” of the refactoring. I’m looking for a better image. I could go with a database icon, but the principle is more general than that. The cloud was confusing. So if you have an idea, please let me know what it is!

Again, thanks for taking a look and giving me the feedback.

Step 0: Problematic Dependency

Step 1: Capture dependency in a single class

Step 2: Raise the abstraction to a domain-level interface

Step 3: Introduce test doubles as needed

"Name that refactoring: 2 - Version 2" by Blu-ray ripper mac

Mon, 19 Apr 2010 04:17:10 -0500

Free download Blu-ray to iPad Mac, you can easily convert Blu ray and DVDs to iPad for playing.

"Name that refactoring: 2 - Version 2" by janeyi

Wed, 24 Mar 2010 03:23:12 -0500

If,overhead trolleyif you’re ,trolley conveyor if you’

re hounded by people trying to bring you down, turn rollerdemanding your time and attention, X678 you can afford to be direct. X458 Because truth

cuts through the bullshit.yy2010.3.24

"Name that refactoring: 2 - Version 2" by Koltuk Yikama

Fri, 08 Jan 2010 11:29:27 -0600

I preferred the cloud as it more underline a potentially complex dependency good system

"Name that refactoring: 2 - Version 2" by hal? y?kama makinas?

Fri, 08 Jan 2010 11:28:44 -0600

I’ll keep looking. I saw one idea. I’ve privately been given several inappropriate recommendations as well. Thanks.

"Name that refactoring: 2 - Version 2" by Cyrille Martraire

Tue, 29 Dec 2009 16:21:10 -0600

a weight (10 tons, like in many cartoons) – it’s something heavy which slows us down>

- exactly, this is also how I feel about a painful dependency.

"Name that refactoring: 2 - Version 2" by Esko Luontola

Sat, 19 Dec 2009 16:56:15 -0600

T-Rex sounds nice. It’s something which we want to keep far away from us. :D

Some ideas I had (but which the spam filter ate) were a weight (10 tons, like in many cartoons) – it’s something heavy which slows us down. Or then a padlock – it’s something which prevents us from progressing.

"Name that refactoring: 2 - Version 2" by Darioush Jalali

Fri, 18 Dec 2009 17:28:02 -0600

I also found the cloud more expressive, the idea that the cloud represents “something general that we don’t show in detail here” is a widely accepted metaphor. Anyhow star or cloud keep up the good work up!

"Name that refactoring: 2 - Version 2" by Chris Salter

Fri, 18 Dec 2009 07:23:28 -0600

It’s funny… When I looked at the first version, even after I figured it out, I never connected it with anything I’ve done. The minute I saw this one, I immediately thought of a project I worked on a few months ago.

The star may not be perfect, but it’s worlds better than the cloud. Personally, I think it would be more fun with a T-Rex.

"Name that refactoring: 2 - Version 2" by Rob Godfrey

Thu, 17 Dec 2009 04:32:37 -0600

How about a target symbol instead of a star, as in the target of the refactoring.

"Name that refactoring: 2 - Version 2" by Brett L. Schuchert

Thu, 17 Dec 2009 02:12:08 -0600

Hum…. I know the star is a bit cheese, but it is, after all, the star of the refactoring!-)

I’ll keep looking. I saw one idea. I’ve privately been given several inappropriate recommendations as well.

"Name that refactoring: 2 - Version 2" by Jacob Stanley

Wed, 16 Dec 2009 17:35:17 -0600

I think the star is too positive. Even though I know what it represents, my emotional side is thinking that it’s bad to move the star further away – after all, he’s so friendly :)

"Name that refactoring: 2 - Version 2" by Dan Bernier

Wed, 16 Dec 2009 12:45:28 -0600

I also dislike the star. If it’s too positive, what do we find if we swing to the other side? What about a bomb, a skull & crossbones? Those may be too harsh—the dependency isn’t fatal, it’s just undesirable.

The “code smells” metaphor suggests a whole range of potential images…

"Name that refactoring: 2 - Version 2" by Daniel Meyer

Wed, 16 Dec 2009 11:13:46 -0600

Somehow this version is much clearer to me than the original version. I think the arrows pointing to the dependencies must help me – and also the terse description text below each figure.

I couldn’t seem to connect with the original version but I got excited when I saw this one, because I could see myself pointing to these and teaching the concept to a co-worker.

It’s also helpful that the step-by-step changes are all on the same screen – I found my eyes jumping up and down the chain of diagrams many times as I absorbed the small difference between each consecutive pair. (It would lose something important, for instance, if each diagram were on a separate page or slide).

"Name that refactoring: 2 - Version 2" by r.

Wed, 16 Dec 2009 09:11:50 -0600

I preferred the “cloud” as it more underline a potentially complex dependency system.

"Name that refactoring: 2 - Version 2" by abi

Wed, 16 Dec 2009 04:22:36 -0600

What is the significance of test double? Is it for making sure that the code doesnt break?

"Name that refactoring: 2 - Version 2" by Giorgio Sironi

Wed, 16 Dec 2009 03:51:04 -0600

As long as you are consistent in using the star there are no problems, but maybe a more expressive image can help. The cloud was too specific as it points only to Internet dependencies.