Object Mentor Blog: Marick's Law

Marick's Law

Uncle Bob — Sat, 29 Nov 2008 14:12:00 -0600

A month ago I was deep in the throes of shipping the current release of FitNesse. I just wanted to get it done. I was close to delivery when I spotted a subtle flaw. To fix this flaw I decided to insert identical if statements into each of 9 implementations of an abstract function.

My green wrist band was glowing a nasty shade of puke. I knew I was duplicating code. I knew that I should use the Template Method pattern. But that just seemed too hard. I was convinced that it would be faster to spew the duplicated code out into the derivatives, get the release done, and then clean it up later.

So this morning I was doing something else, and I spotted this duplicated code. I sighed, as I looked down at my green wrist band, and thought to myself that I’d better eat my own dog food and clean this mess up before it gets any worse. I was dreading it.

I made sure that every occurrence of the statement was identical. Then I went to the base class with the intention of refactoring a Template Method. When, what to my wondering eyes should appear, but a Template Method that was already there.

I sheepishly copied and pasted the if statement from one of the derivatives into the Template Method, and then deleted the other eight instances.

I ran the tests.

They all passed.

Damn.

My green wrist band is shouting: “I TOLD YOU SO!”

For my penance I did 20 recitations of Marick’s law. “When it comes to code it never pays to rush.”

"Marick's Law" by Tips For Bowling

Thu, 20 Oct 2011 15:43:40 -0500

One of the best things to come out of the home computer revolution could be the general and widespread understanding of how severely limited logic really is.

"Marick's Law" by Puma espera shoes

Tue, 27 Sep 2011 02:30:07 -0500

The fifty years history of PUMA are written in the history of the great accomplishments of movement. PUMA with Pele went into the final of World Cup championship,While with tennis player Beck always won at wimbledon lawn of soil. And made cooperation with the most of the top athletes and constantly strive for the latest technology to make the best sports equipment. Puma founder,Rudolph Deisler established the PUMA brand in 1948 in Germany.for decades puma has been the important actor in the sport.During the recent years, the more successful combination of pop sports,puma become one of the favorite brand for young people.

"Marick's Law" by provillus

Thu, 28 Jul 2011 17:19:50 -0500

hmm ,i’m not sure if this is what i’m looking for but anyway this is interresting and could be useful some day,thanks for taking time to write such cool stuff

"Marick's Law" by avocat algerien

Fri, 10 Jun 2011 12:19:09 -0500

It is an article that reaches our view point by point avocat constantine

"Marick's Law" by Hancy

Wed, 08 Jun 2011 10:48:44 -0500

Hello Friend,Whichever style of Fashion Shoes you’re looking for, classical, fashionable, lovely or the latest design, you can find your favorite designer shoes in www.dunkpage.com ,several days ago I bought one pair of shoes from there,It’s beautiful and very comfortable!

"Marick's Law" by christian louboutin shoes on sale

Fri, 03 Jun 2011 06:15:22 -0500

Have the christian louboutin patent leather pumps is a happy thing. Here have the most complete kinds of christian louboutin leather platform pumps.

"Marick's Law" by Hermes belt

Sat, 07 May 2011 06:36:23 -0500

Hermes belt store offers high quality and cheap designer belts, please have a look.

"Marick's Law" by Hermes belts

Sat, 07 May 2011 06:31:53 -0500

Strongly recommended for shopping at Hermes belts store.

"Marick's Law" by okey oyunu oyna

Wed, 27 Apr 2011 15:51:17 -0500

Thanks uncle bob.

Dunyanin en büyük online okey oyunu bu sitede sizleri bekliyor. Gerçek kisilerle sohbet ederek okey oyunu oyna ve internette online oyun oynamanin zevkini çikar.

"Marick's Law" by Disount Christian Louboutin

Thu, 07 Apr 2011 22:26:00 -0500

This is a superb posting, I identified your weblog web page executing study google for any related topic and came to this. I couldnt uncover to substantially supplemental info and details on this write-up, so it was pleasant to find this 1. I’ll in all probability finish up currently being again once more to appear at another content articles that you’ve got yet another time. yhm20110408 Disount Christian Louboutin

"Marick's Law" by Gucci Outlet Online

Tue, 05 Apr 2011 21:42:40 -0500

If psychologically prepared, all preparations have been completed!

"Marick's Law" by Yalova Emlak

Sun, 20 Mar 2011 07:25:36 -0500

Thanks for this article.I like its.As to me it’s good job.I wait ur next articles and I will read ur new articles.I come to this site.Because i like this site.

"Marick's Law" by Sunglass

Thu, 10 Mar 2011 04:35:37 -0600

At fashion-world4u you find Imitation

"Marick's Law" by dswehfhh

Wed, 09 Mar 2011 12:30:27 -0600

We are the professional scarfs manufacturer, scarfs supplier, scarfs factory, custom scarfs.

"Marick's Law" by lv backpack

Thu, 03 Mar 2011 00:10:31 -0600

lv backpack have fairly very rated for rather a few of elements just like pattern durability and ease of use

"Marick's Law" by Monster beats

Mon, 28 Feb 2011 02:49:14 -0600

Headphonesyou like Bose Headphonesso Bose Earphonesthat Sony Earphonesno AKG Headphoneschoise Sony Headphonesand all kinds of headphones UKYou can see the Monster beatsdo monster beats headphonessale online Beats by dreyourcolleagues buy Beats dr dresuch as Beats dre and Beats by dr dreso on

"Marick's Law" by ghd australia

Thu, 17 Feb 2011 19:30:15 -0600

GHD australia have fairly very rated for rather a few of elements just like pattern durability and ease of use.

"Marick's Law" by Tenant Screening

Thu, 17 Feb 2011 15:06:06 -0600

I’m frequently see people doing the same mistakes when it comes to TDD. People test methods and implementations, which leads to tests that are too closely coupled to the implementation, difficult to maintain and refactor, and seems to slow down development and changes.

"Marick's Law" by Criminal Records

Thu, 10 Feb 2011 15:55:09 -0600

When, what to my wondering eyes should appear, but a Template Method that was already there.

"Marick's Law" by Gucci belts

Wed, 09 Feb 2011 01:00:14 -0600

gucci belts for men, gucci belts, gucci mens belt, gucci mens belts.

"Marick's Law" by replica belts

Wed, 09 Feb 2011 00:59:26 -0600

replica gucci belts, replica gucci belt, replica gucci belts for men, replica gucci mens belt.

"Marick's Law" by Men's belts

Wed, 09 Feb 2011 00:59:15 -0600

Men’s belts, LV men’s belts, Gucci men’s belts, Hermes men’s belts.

"Marick's Law" by hermes belt

Wed, 09 Feb 2011 00:57:55 -0600

Hermes belts, Hermes belt, Hermes belts for men, Hermes mens belt, dupont lighter, dupont lighters, st dupont lighter, s.t. dupont lighters.

"Marick's Law" by iPad PDF Transfer for Mac

Fri, 21 Jan 2011 20:49:09 -0600

I really like this essay. Thank you for writing it so seriously. I want to recommend it for my friends strongly. iPad PDF Transfer for Mac can help you transfer ebooks in PDF format from ipad to mac/iTunes.

"Marick's Law" by Silicone Molding

Wed, 29 Dec 2010 21:22:01 -0600

Intertech Machinery Inc. provides the most precise Plastic Injection Mold and Rubber Molds from Taiwan. With applying excellent unscrewing device in molds, Intertech is also very professional for making flip top Cap Molds in the world.