Object Mentor Blog: Now 'and' for something completely different.

Now 'and' for something completely different.

Uncle Bob — Thu, 26 Jun 2008 13:16:00 -0500

My son Justin is working as a Ruby apprentice for my son Micah at 8th light. We were sitting at the kitchen table, and he showed me a function he was writing. In the midst of the function I saw this:

handle_batch(item) and display_batch(item) while items_remaining?

I looked hard at this and then I said: “Justin, I don’t think you understand what and does.

He said: “I think I do.” and he pointed me to a website which showed 21 Ruby tricks “you should be using in your own code.”

Trick #9 was the use of the and keyword to couple statements together to make “one liners”. It was billed as a trick that [cough] “more confident” Ruby programmers use.

So I got the pickaxe book out and looked up the and keyword. I showed Justin where it said that the second clause won’t be executed if the first clause is false (or nil!) So if handle_batch ever returned nil, then display_batch would never be called.

Warning bells were going off in my head. This was clearly an unintended use of the and keyword that could have rather nasty repercussions. I thought it was somewhat irresponsible for a website that boasted expertise in programming to tell people they should be using a dangerous stunt like this.

However, handle_batch did not return nil, so the and worked well enough in this case; and we had more to do. So I made my point to Justin and then we kept working, leaving the and in place.

An hour later we were making changes to a function. Suddenly a whole bunch of our tests broke. (You know what I’m going to say, don’t you?) The failure mode didn’t make any sense. Suddenly a whole bunch of processing simply wasn’t getting done.

It was Justin who said: “Wow, I’ll bet it’s that and. And it was. The change we had made had indirectly caused handle_batch to return a nil.

OK, this was a fun little story. You might think the moral is “don’t use and for one-liners” or “don’t trust websites that claim expertise”. Yes, those would be good conclusions to draw. But I’m concerned about something else.

The “and trick” is clever. In programming, clever != smart. (OK, sorry, that was clever…) Using a keyword like and in a manner for which it was not intended, and in a way that is not guaranteed to work in all cases, is risky. It bothers me.

By the same token it bothers me that so many Ruby programmers use the ||= trick for lazy initialization. I know it works. I know it’s a standard idiom. I’m not trying to stop people from doing it. Hell, I use it too because it’s become a standard idiom. But it bothers me nonetheless because it entered our vocabulary of idioms because it was clever trick; and clever little tricks have a way of turning into nasty little surprises.

Ruby is a fun and powerful language. But that doesn’t mean we should go out of our way to be clever. We shouldn’t be eager to adopt quirky little idioms and erudite little stunts just because they are cute, or neat, or nifty. Code is hard enough to understand without having to think sideways through the next novel application of the ?: operator.

Professionals write clear and clean code. They use their language well. They use their language efficiently. But they don’t aspire to be master tricksters. Rather, they prove their professionalism by writing code that needs no explanation.

"Now 'and' for something completely different." by Beats By Dre Canada

Tue, 08 Nov 2011 23:07:00 -0600

And she was the awards wear a by fresh beef made of meat pack, again making her a topic of the world.

"Now 'and' for something completely different." by alwadifa

Sat, 05 Nov 2011 17:56:00 -0500

I liked you blog so im going bookmark it with my prefered websites, you have posted an amazing posts so thank you I liked you blog so im going bookmark it with my prefered websites, you have posted an amazing posts so thank you

"Now 'and' for something completely different." by flac converter

Thu, 27 Oct 2011 02:55:05 -0500

good post, i think so.Thank you!

"Now 'and' for something completely different." by flac converter

Thu, 27 Oct 2011 02:50:03 -0500

Thank you for sharing, I’ll definitely dig deeper into it.

"Now 'and' for something completely different." by Tips For Bowling

Thu, 20 Oct 2011 13:26:19 -0500

This dullness of vision regarding the importance of the general welfare to the individual is the measure of the failure of our schools and churches to teach the spiritual significance of genuine democracy. Henry A. Wallace

"Now 'and' for something completely different." by CASINO DAILY NEWS

Thu, 20 Oct 2011 06:08:24 -0500

Thanks a lot for providing the great info is visible in this blog that to sharing the great info is visible in this blog. I am very much inspired the great technology in this blog.

"Now 'and' for something completely different." by CASINO SINAZ

Thu, 20 Oct 2011 06:06:23 -0500

I am very much satisfied by the great technology in this website that to sharing the great services in this blog. Thanks a lot for providing the amazing info is visible in this blog that to sharing the great services in this blog.

"Now 'and' for something completely different." by online poker just

Thu, 20 Oct 2011 06:04:29 -0500

This is very much happy for using the great approach is visible in this blog that to the way of presentation is really cool. Thanks a lot for providing the great info is visible in this blog.

"Now 'and' for something completely different." by bingo journal topics

Thu, 20 Oct 2011 06:03:09 -0500

I had really admired for the great info is visible in this blog that to sharing the great technology in this blog. Thanks a lot for providing the great info is visible in this blog.

"Now 'and' for something completely different." by ysbearing

Wed, 19 Oct 2011 03:42:06 -0500

Slewing bearing called slewing ring bearings, is a comprehensive load to bear a large bearing, can bear large axial, radial load and overturning moment.

"Now 'and' for something completely different." by how to become

Wed, 05 Oct 2011 02:47:18 -0500

I had How To Become An Animal Cop really great technology How To Become Cameraman is visible in this blog and How To Become A Dominatrix using the nice services in this blog How To Become A Hair Model This how To Become A Travel Agent From Home is very much How To Become A Fashion Photographer happy for using How To Become Neurologist the nice services in this blog and really wonderful technology is visible in this blog

"Now 'and' for something completely different." by how to become

Wed, 05 Oct 2011 02:45:44 -0500

I am regular How To Become A Fireman visiting the nice info is How To Become A Corporation visible in this blog that to How To Become A Wedding Consultant providing the updated How To Become A Travel Writer info is visible in this blog. Thanks a lot for providing the great info is visible in this blog

"Now 'and' for something completely different." by how to become

Wed, 05 Oct 2011 02:43:40 -0500

I am How To Become A California Resident very How To Become A GAME WARDEN much happy for using How To Become A Real Estate Appraiser the great technology How To Become A Politician is visible in this blog and sharing the nice services in this blog

"Now 'and' for something completely different." by Coroner Job Description

Fri, 30 Sep 2011 02:01:16 -0500

This is very amazing info in this blog that to very much enjoyed for this info in this blog. Coroner Job Description|Medical Technologist Job Description|Corrections Officer Job Description|Financial Analyst Job Description

"Now 'and' for something completely different." by dvd ripper

Sun, 11 Sep 2011 07:18:33 -0500

good post, i think so.Thank you!

"Now 'and' for something completely different." by dvd ripper

Sun, 11 Sep 2011 07:17:25 -0500

good post, i think so.Thank you!

"Now 'and' for something completely different." by beats by dre store

Tue, 23 Aug 2011 03:23:04 -0500

for a great blog post writer titlehigh quality headphones new design headphones,kep the great job happening

"Now 'and' for something completely different." by Jades Company

Tue, 16 Aug 2011 00:45:40 -0500

nice blog thanks for the comments i wanna share this one especially to all applicants who need a best resume

"Now 'and' for something completely different." by Bowtrol

Mon, 08 Aug 2011 15:49:04 -0500

Blog posts about wedding and bridal are always rare to find , at least with great quality,you qualify for a great blog post writer title,kep the great job happening

"Now 'and' for something completely different." by mp3 converter

Sat, 30 Jul 2011 02:56:07 -0500

Good Information Very nice post.

"Now 'and' for something completely different." by graham tx

Sat, 18 Jun 2011 05:23:10 -0500

I definitely desired to deliver a quick concept to thank you for the nice tips and hints you’re posting on this website. My time-consuming internet appear up has now been rewarded with helpful strategies to exchange with my family and friends. I ?d claim that we readers fact are truly blessed to dwell in a helpful community with incredibly some great individuals with insightful points. I really feel really grateful to get discovered the webpage and appear ahead to a lot of additional entertaining moments reading right here. Thanks a good deal again for a good deal of things.

"Now 'and' for something completely different." by graham tx

Sat, 18 Jun 2011 05:19:49 -0500

Really impressed! Everything is very open and very clear explanation of issues. It contains truly information. Your website is very useful. Big buddy in the picture.Thanks for sharing. Looking forward to more!graham tx

"Now 'and' for something completely different." by graham tx

Sat, 18 Jun 2011 05:18:30 -0500

It is nice to find a site about my interest. My first visit to your site is been a big help. Thank you for the efforts you been putting on making your site such an interesting and informative place to browse through. I’ll be visiting your site again to gather some more valuable information. You truly did a good job.graham tx

"Now 'and' for something completely different." by Commercial photography

Tue, 14 Jun 2011 02:41:49 -0500

All the contents you mentioned in post is too good and can be very useful. I will keep it in mind, thanks for sharing the information keep updating, looking forward for more posts. Thanks

"Now 'and' for something completely different." by beats by dr dre headphones

Wed, 08 Jun 2011 20:26:41 -0500

Beats by dr dre studio with look after talk in white. extra attributes on Monster Beats By Dr. Dre Pro Headphones Black a specific tri-fold design and design and carrying circumstance which make for compact and uncomplicated safe-keeping when not in use. Beats by dr dre solo .